fix: add extensions field to PayloadError per GraphQL spec#5289
Open
PHILLIPS71 wants to merge 3 commits into
Open
fix: add extensions field to PayloadError per GraphQL spec#5289PHILLIPS71 wants to merge 3 commits into
PHILLIPS71 wants to merge 3 commits into
Conversation
Contributor
|
@evanyeung has imported this pull request. If you are a Meta employee, you can view this in D106027144. |
Contributor
|
Nice catch! This looks correct as per the spec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GraphQL spec (https://spec.graphql.org/September2025/#sec-Errors) states that errors may include an extensions entry whose value must be a map with no additional restrictions on its contents. PayloadError was missing this field.
This also propagates extensions through to
TRelayFieldErrorso the field is preserved during normalization and available to consumers. As a side effect, stale inline type annotations inRelayErrorTrie.jsthat manually duplicated the error shape have been replaced withTRelayFieldErrordirectly, and a mutation of a ReadonlyArray path via unshift has been replaced with an immutable spread.