Document WriteBatchWithIndex prefix iterator behavior#14774
Open
richinmrudul wants to merge 1 commit into
Open
Document WriteBatchWithIndex prefix iterator behavior#14774richinmrudul wants to merge 1 commit into
richinmrudul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Documents that WriteBatchWithIndex::NewIteratorWithBase cannot infer the ReadOptions or prefix extractor used to create the base iterator. In particular, prefix_same_as_start on the base iterator is not applied to keys from the write batch, so callers that need prefix-bounded iteration must enforce the prefix boundary themselves.
Adds a focused test showing that a plain DB iterator respects prefix_same_as_start while the merged WriteBatchWithIndex iterator can still return in-batch keys outside the seek prefix.
Refs #14610
Test Plan:
make write_batch_with_index_test -j8
./write_batch_with_index_test --gtest_filter='Prefix'
git diff --check
make check-sources