fix clippy lints

Summary:
[`clippy::uninlined_format_args`](https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args) will become an error on OSS buck2 builds with the `1.88.0` toolchain since `clippy::all` so fixing these first here via:
```
$ buck2 run fbcode//common/rust/tools/rustfix2:rustfix -- --clippy --target fbcode//buck2/app/... --target fbcode//buck2/allocative/... --target fbcode//buck2/buck2_tpx_cli/... --target fbcode//buck2/dice/... --target fbcode//buck2/dice_replay/... --target fbcode//buck2/facebook/... --target fbcode//buck2/gazebo/... --target fbcode//buck2/host_sharing/... --target fbcode//buck2/integrations/... --target fbcode//buck2/remote_execution/... --target fbcode//buck2/shed/... --target fbcode//buck2/starlark-rust/... --target fbcode//buck2/superconsole/...
$ find fbcode/buck2/ -name *.rs | xargs arc lint --take RUSTFMT -a
```
plus some manual fixes for `build.rs` files and OSS-only code blocks.

Reviewed By: capickett

Differential Revision: D78065152

fbshipit-source-id: 544d9bcabed0bb08d4fcf38410a46592e477093a

Author: diliop

allocative/allocative/src/flamegraph.rs

@@ -565,8 +565,7 @@ mod tests {
                 Struct;p;x 13\n\
             ",
             tree.to_flame_graph().0.write(),
-            "{:#?}",
-            tree,
+            "{tree:#?}",
         );
     }
 
@@ -602,8 +601,7 @@ mod tests {
             Struct;p 12\n\
         ",
             tree.to_flame_graph().0.write(),
-            "{:#?}",
-            tree,
+            "{tree:#?}",
         );
     }
 

allocative/allocative/src/golden.rs

@@ -53,7 +53,7 @@ fn make_golden<T: Allocative>(value: &T) -> (String, String) {
         header = golden_header()
             .lines()
             .fold(String::new(), |mut output, line| {
-                let _ = writeln!(output, "# {}", line);
+                let _ = writeln!(output, "# {line}");
                 output
             })
     );

allocative/allocative_derive/src/derive_allocative.rs

@@ -233,7 +233,7 @@ fn fields_unnamed_names(fields: &FieldsUnnamed) -> syn::Result<Vec<Ident>> {
         .unnamed
         .iter()
         .enumerate()
-        .map(|(i, f)| Ok(Ident::new(&format!("f{}", i), f.span())))
+        .map(|(i, f)| Ok(Ident::new(&format!("f{i}"), f.span())))
         .collect()
 }
 

gazebo/display_container/src/lib.rs

@@ -302,7 +302,7 @@ mod tests {
                     "]",
                     ": ",
                     // just wrap with `"` to make it clearer in the output
-                    self.0.iter().map(|(k, v)| (k, format!("\"{}\"", v))),
+                    self.0.iter().map(|(k, v)| (k, format!("\"{v}\""))),
                 )
             }
         }

gazebo/dupe_derive/src/dupe.rs

@@ -54,7 +54,7 @@ fn derive_dupe_explicit(
     let check_each_field_dupe = check_each_field_dupe(all_fields);
 
     let check_func_name = Ident::new(
-        &format!("__implicit_dupe_check_for_fields_of_{}", name),
+        &format!("__implicit_dupe_check_for_fields_of_{name}"),
         name.span(),
     );
 

gazebo/dupe_derive/src/util.rs

@@ -99,7 +99,7 @@ fn duplicate_variant(data: &Variant, duplicate: &TokenStream) -> TokenStream {
                 .iter()
                 .enumerate()
                 .map(|(i, f)| {
-                    let var = Ident::new(&format!("v{}", i), f.span());
+                    let var = Ident::new(&format!("v{i}"), f.span());
                     (quote! {#var}, quote! {#duplicate(#var)})
                 })
                 .unzip();

gazebo/gazebo_derive/src/variant.rs

@@ -78,7 +78,7 @@ pub(crate) fn derive_unpack_variants(input: DeriveInput) -> syn::Result<proc_mac
             for field in variant.fields.iter() {
                 patterns.push(field.ident.clone().map_or_else(
                     || {
-                        let id = Ident::new(&format!("_v{}", count), Span::call_site());
+                        let id = Ident::new(&format!("_v{count}"), Span::call_site());
                         count += 1;
                         id
                     },

gazebo/strong_hash_derive/src/lib.rs

@@ -70,7 +70,7 @@ pub fn derive_hash(input: TokenStream) -> TokenStream {
                                 .iter()
                                 .enumerate()
                                 .map(|(index, field)| {
-                                    Ident::new(&format!("x{}", index), field.span())
+                                    Ident::new(&format!("x{index}"), field.span())
                                 })
                                 .collect();
                             quote! {

starlark/src/analysis/types.rs

@@ -138,7 +138,7 @@ impl Display for EvalMessage {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         write!(f, "{}: {}:", self.severity, self.path)?;
         if let Some(span) = self.span {
-            write!(f, "{}", span)?;
+            write!(f, "{span}")?;
         }
         write!(f, " {}", self.description)
     }
@@ -162,7 +162,7 @@ impl EvalMessage {
             span: None,
             severity: EvalSeverity::Error,
             name: "error".to_owned(),
-            description: format!("{:#}", x),
+            description: format!("{x:#}"),
             full_error_with_span: None,
             original: None,
         }
@@ -180,7 +180,7 @@ impl EvalMessage {
             span: Some(resolved_span),
             severity: EvalSeverity::Error,
             name: "error".to_owned(),
-            description: format!("{:#}", message),
+            description: format!("{message:#}"),
             full_error_with_span: Some(full_error.to_string()),
             original: Some(original),
         }

starlark/src/analysis/unused_loads/find.rs

@@ -130,7 +130,7 @@ pub(crate) fn find_unused_loads(
 
     for top in top_level_stmts(&module_scopes.cst) {
         top.visit_ident(|ident| {
-            println!("visit ident: {:?}", ident);
+            println!("visit ident: {ident:?}");
             let ResolvedIdent::Slot(Slot::Module(_), binding_id) = ident
                 .payload
                 .ok_or_else(|| anyhow::anyhow!("ident is not resolved (internal error)"))?