fix clippy lints & buck2 OSS CI errors

Summary:
Fix existing 1.90.0 and new 1.91.1 clippy lints via:
```
buck2 run fbcode//common/rust/tools/rustfix2:rustfix -- --clippy --target fbcode//common/rust/... --target fbcode//buck2/allocative/... --target fbcode//buck2/app/... --target fbcode//buck2/buck2_tpx_cli/... --target fbcode//buck2/dice/... --target fbcode//buck2/dice_replay/... --target fbcode//buck2/facebook/... --target fbcode//buck2/gazebo/... --target fbcode//buck2/host_sharing/... --target fbcode//buck2/integrations/... --target fbcode//buck2/remote_execution/... --target fbcode//buck2/shed/... --target fbcode//buck2/starlark-rust/... --target fbcode//buck2/superconsole/... --target fbcode//remote_execution/... --target fbcode//target_determinator/...
```

plus OSS errors from `fbcode/buck2/scripts/ci.sh`

Reviewed By: dtolnay

Differential Revision: D87088632

fbshipit-source-id: 956943c547bb2ebe5aa8b031d741e9467233352e

Author: diliop

shed/facet/proc_macros/factory_impl.rs

@@ -555,27 +555,24 @@ impl Facets {
     }
 
     fn extract_facet_return_type(sig: &mut Signature) -> Result<(Type, Fallibility), Error> {
-        if let ReturnType::Type(_, ty) = &mut sig.output {
-            if let Type::Path(type_path) = &mut **ty {
-                if let Some(segment) = type_path.path.segments.last_mut() {
-                    match &mut segment.arguments {
-                        PathArguments::None => {
-                            // The type path should be directly to the facet.
-                            let facet_ty = (**ty).clone();
-                            return Ok((facet_ty, Fallibility::Infallible));
-                        }
-                        PathArguments::AngleBracketed(arguments) => {
-                            if let Some(GenericArgument::Type(first_ty)) =
-                                arguments.args.first_mut()
-                            {
-                                // This type should be directly to the facet.
-                                let facet_ty = first_ty.clone();
-                                return Ok((facet_ty, Fallibility::Fallible));
-                            }
-                        }
-                        _ => {}
+        if let ReturnType::Type(_, ty) = &mut sig.output
+            && let Type::Path(type_path) = &mut **ty
+            && let Some(segment) = type_path.path.segments.last_mut()
+        {
+            match &mut segment.arguments {
+                PathArguments::None => {
+                    // The type path should be directly to the facet.
+                    let facet_ty = (**ty).clone();
+                    return Ok((facet_ty, Fallibility::Infallible));
+                }
+                PathArguments::AngleBracketed(arguments) => {
+                    if let Some(GenericArgument::Type(first_ty)) = arguments.args.first_mut() {
+                        // This type should be directly to the facet.
+                        let facet_ty = first_ty.clone();
+                        return Ok((facet_ty, Fallibility::Fallible));
                     }
                 }
+                _ => {}
             }
         }
         Err(Error::new_spanned(
@@ -621,10 +618,10 @@ impl FactoryParam {
 }
 
 fn extract_type_ident(ty: &Type) -> Result<Ident, Error> {
-    if let Type::Path(type_path) = ty {
-        if let Some(ident) = type_path.path.get_ident() {
-            return Ok(ident.clone());
-        }
+    if let Type::Path(type_path) = ty
+        && let Some(ident) = type_path.path.get_ident()
+    {
+        return Ok(ident.clone());
     }
     Err(Error::new_spanned(
         ty,

shed/futures_ext/src/stream/yield_periodically.rs

@@ -99,10 +99,10 @@ impl<S: Stream> Stream for YieldPeriodically<'_, S> {
         match this.current_budget.checked_sub(elapsed) {
             Some(new_budget) => *this.current_budget = new_budget,
             None => {
-                if let Some(on_large_overshoot) = &this.on_large_overshoot {
-                    if (elapsed - current_budget) > *this.budget * BUDGET_OVERSHOOT_MULTIPLIER {
-                        (on_large_overshoot)(current_budget, elapsed);
-                    }
+                if let Some(on_large_overshoot) = &this.on_large_overshoot
+                    && (elapsed - current_budget) > *this.budget * BUDGET_OVERSHOOT_MULTIPLIER
+                {
+                    (on_large_overshoot)(current_budget, elapsed);
                 }
                 *this.must_yield = true;
                 *this.current_budget = *this.budget;

shed/slog_glog_fmt/src/collector_serializer.rs

@@ -277,11 +277,11 @@ mod tests {
     #[test]
     fn test_ignoring() {
         let mut rng: StdRng = SeedableRng::from_seed([2; 32]);
-        let normal = vec![
+        let normal = [
             TestKv::new("test1", &mut rng),
             TestKv::new("test2", &mut rng),
         ];
-        let ignore = vec![
+        let ignore = [
             TestKv::new("ignore1", &mut rng),
             TestKv::new("ignore2", &mut rng),
         ];