feat: Add IPADDRESS support to Arbitrary aggregate function

Summary:
The arbitrary() aggregate function was throwing NOT_IMPLEMENTED when used
with IPADDRESS type. This was caught by the aggregation fuzzer.

This change adds a check for isIPAddressType() for HUGEINT type in
ArbitraryAggregate, allowing IPADDRESS values to be properly handled.

Differential Revision: D92026533

Author: pratikpugalia

velox/functions/prestosql/aggregates/ArbitraryAggregate.cpp

@@ -19,6 +19,7 @@
 #include "velox/expression/FunctionSignature.h"
 #include "velox/functions/lib/aggregates/SimpleNumericAggregate.h"
 #include "velox/functions/lib/aggregates/SingleValueAccumulator.h"
+#include "velox/functions/prestosql/types/IPAddressType.h"
 
 using namespace facebook::velox::functions::aggregate;
 
@@ -446,7 +447,7 @@ void registerArbitraryAggregate(
           case TypeKind::BIGINT:
             return std::make_unique<ArbitraryAggregate<int64_t>>(inputType);
           case TypeKind::HUGEINT:
-            if (inputType->isLongDecimal()) {
+            if (inputType->isLongDecimal() || isIPAddressType(inputType)) {
               return std::make_unique<ArbitraryAggregate<int128_t>>(inputType);
             }
             VELOX_NYI();

velox/functions/prestosql/aggregates/tests/ArbitraryTest.cpp

@@ -19,6 +19,7 @@
 #include "velox/exec/tests/utils/TempDirectoryPath.h"
 #include "velox/functions/lib/aggregates/tests/utils/AggregationTestBase.h"
 #include "velox/functions/lib/window/tests/WindowTestBase.h"
+#include "velox/functions/prestosql/types/IPAddressType.h"
 
 using namespace facebook::velox::exec::test;
 using namespace facebook::velox::functions::aggregate::test;
@@ -407,6 +408,34 @@ TEST_F(ArbitraryTest, shortDecimal) {
   testAggregations({data}, {"c0"}, {"arbitrary(c1)"}, {expectedResult});
 }
 
+TEST_F(ArbitraryTest, ipAddress) {
+  auto data = makeRowVector(
+      {// Grouping key.
+       makeFlatVector<int64_t>({1, 1, 2, 2, 3, 3, 4, 4}),
+       // IPADDRESS values
+       makeNullableFlatVector<int128_t>(
+           {ipaddress::tryGetIPv6asInt128FromString("192.168.1.1").value(),
+            ipaddress::tryGetIPv6asInt128FromString("192.168.1.1").value(),
+            ipaddress::tryGetIPv6asInt128FromString("10.0.0.1").value(),
+            ipaddress::tryGetIPv6asInt128FromString("10.0.0.1").value(),
+            std::nullopt,
+            std::nullopt,
+            std::nullopt,
+            ipaddress::tryGetIPv6asInt128FromString("172.16.0.1").value()},
+           IPADDRESS())});
+
+  auto expectedResult = makeRowVector(
+      {makeFlatVector<int64_t>({1, 2, 3, 4}),
+       makeNullableFlatVector<int128_t>(
+           {ipaddress::tryGetIPv6asInt128FromString("192.168.1.1").value(),
+            ipaddress::tryGetIPv6asInt128FromString("10.0.0.1").value(),
+            std::nullopt,
+            ipaddress::tryGetIPv6asInt128FromString("172.16.0.1").value()},
+           IPADDRESS())});
+
+  testAggregations({data}, {"c0"}, {"arbitrary(c1)"}, {expectedResult});
+}
+
 class ArbitraryWindowTest : public WindowTestBase {};
 
 TEST_F(ArbitraryWindowTest, basic) {