Repository navigation
Commit a5f2853
committed
Fix review findings in the second pass
A five-lens review of 7d7597b..2b29560, each finding checked by a
skeptic, confirmed these.
- Theme switch: a palette list without toggle keys draws Material's
form but no label, so the switch showed and threw on click. It now
shows only when a label exists, and never clicks a missing one.
- Neighbour badges: a prerequisite read "Uses" while its accessible
name said "used by <selection>". Badges now read in the card's own
direction, "Used by <selection>" or "Uses <selection>", truncated.
- Phone handle: at half its title said "Close reading", but a tap
opens the full reader. It now says "Expand reading" there.
- Hover: leaving a card cleared the preview on the next tick, so
crossing the gap to the next card flashed the whole map back.
Leaving now waits 120 ms, as entering does; blur still acts at once.
- Tablet toolbar: with "Show unlinked" off, "Filter: … · linked only"
and the link still overflowed the second row below about 785px. The
filter now grows from 100px into the row's free space and truncates
its summary rather than wrap.
- Touch screens: the 44px Fit made the row taller in Map than in
Results or Sources, so the head moved on every view switch. The zoom
group now keeps its place, hidden, in the list views. The theme
switch gets the same 44px target on coarse pointers.
- 681 to 720px: the phone handle lacked the 680px block's width,
border and font, so it shrank to its title and showed the button
border. Its own rule now sets them.
Tests: the tablet toolbar case runs at 721, 800 and 1000px with the
longest summary; a new browser test moves the mouse from one card to
the next and checks that no card outside both neighbourhoods lights
in between; the five-area test checks what the area meta and summary
show, not only their text; search results are checked for their
576px minimum; the four unbounded handle loops are bounded and end in
an assertion.1 parent 47c045b commit a5f2853
7 files changed
Lines changed: 113 additions & 37 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
698 | 698 | | |
699 | 699 | | |
700 | 700 | | |
| 701 | + | |
701 | 702 | | |
702 | | - | |
| 703 | + | |
703 | 704 | | |
704 | 705 | | |
705 | | - | |
| 706 | + | |
706 | 707 | | |
707 | 708 | | |
708 | 709 | | |
| |||
1369 | 1370 | | |
1370 | 1371 | | |
1371 | 1372 | | |
1372 | | - | |
| 1373 | + | |
1373 | 1374 | | |
1374 | 1375 | | |
1375 | 1376 | | |
| |||
1411 | 1412 | | |
1412 | 1413 | | |
1413 | 1414 | | |
1414 | | - | |
| 1415 | + | |
1415 | 1416 | | |
1416 | 1417 | | |
1417 | 1418 | | |
1418 | | - | |
| 1419 | + | |
1419 | 1420 | | |
1420 | 1421 | | |
1421 | 1422 | | |
| |||
1628 | 1629 | | |
1629 | 1630 | | |
1630 | 1631 | | |
1631 | | - | |
| 1632 | + | |
1632 | 1633 | | |
1633 | 1634 | | |
1634 | 1635 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1020 | 1020 | | |
1021 | 1021 | | |
1022 | 1022 | | |
| 1023 | + | |
| 1024 | + | |
| 1025 | + | |
| 1026 | + | |
| 1027 | + | |
| 1028 | + | |
| 1029 | + | |
| 1030 | + | |
| 1031 | + | |
| 1032 | + | |
| 1033 | + | |
| 1034 | + | |
| 1035 | + | |
| 1036 | + | |
| 1037 | + | |
| 1038 | + | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
1023 | 1061 | | |
1024 | 1062 | | |
1025 | 1063 | | |
| |||
1523 | 1561 | | |
1524 | 1562 | | |
1525 | 1563 | | |
| 1564 | + | |
1526 | 1565 | | |
1527 | 1566 | | |
1528 | 1567 | | |
| |||
1720 | 1759 | | |
1721 | 1760 | | |
1722 | 1761 | | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
1723 | 1765 | | |
1724 | 1766 | | |
1725 | 1767 | | |
| |||
2486 | 2528 | | |
2487 | 2529 | | |
2488 | 2530 | | |
2489 | | - | |
| 2531 | + | |
2490 | 2532 | | |
2491 | 2533 | | |
2492 | 2534 | | |
| |||
2496 | 2538 | | |
2497 | 2539 | | |
2498 | 2540 | | |
| 2541 | + | |
| 2542 | + | |
| 2543 | + | |
2499 | 2544 | | |
2500 | 2545 | | |
2501 | 2546 | | |
| |||
0 commit comments