--clang-tidy suggestions

Author: jturner65

src/esp/core/Configuration.h

@@ -283,7 +283,7 @@ class Configuration {
 
   int getNumEntries() const { return numEntries; }
 
-  bool hasValues() { return numEntries > 0; }
+  bool hasValues() const { return numEntries > 0; }
 
   bool hasValue(const std::string& key) const {
     return (configMap_.count(key) > 0) || (intMap_.count(key) > 0) ||

src/esp/io/json.cpp

@@ -57,8 +57,9 @@ bool writeJsonToFile(const JsonDocument& document,
   return writeSuccess;
 }
 
-int loadJsonIntoConfiguration(const JsonGenericValue& jsonObj,
-                              std::shared_ptr<core::Configuration> config) {
+int loadJsonIntoConfiguration(
+    const JsonGenericValue& jsonObj,
+    const std::shared_ptr<core::Configuration>& config) {
   // count number of valid user config settings found
 
   int numConfigSettings = 0;

src/esp/io/json.h

@@ -64,7 +64,7 @@ esp::vec3f jsonToVec3f(const JsonGenericValue& jsonArray);
  */
 int loadJsonIntoConfiguration(
     const JsonGenericValue& jsonObj,
-    std::shared_ptr<esp::core::Configuration> configPtr);
+    const std::shared_ptr<esp::core::Configuration>& configPtr);
 
 /**
  * @brief Check passed json doc for existence of passed jsonTag as value of