Skip to content

Commit c82e43f

Browse files
Sam Calabresemeta-codesync[bot]
authored andcommitted
BvhEmbree handles Embree 4.3's RTC_ERROR_LEVEL_ZERO_RAYTRACING_SUPPORT_MISSING (#1703)
Summary: Pull Request resolved: #1703 Embree 4.3 added `RTC_ERROR_LEVEL_ZERO_RAYTRACING_SUPPORT_MISSING` to `RTCError` (raised only by the SYCL device). `BvhEmbree.cpp`'s `switch` over `RTCError` builds with `-Werror,-Wswitch` and has no `default:`, so axel stops compiling once `//third-party/embree/4.1.0:embree` resolves to Embree 4.4.0 (the in-place upgrade in the next diff, D127066765). The new case logs like the others. It is guarded with `#if RTC_VERSION >= 40300`, so building against today's Embree 4.1.0, and axel's open-source CMake build against an older Embree, are unchanged. Split out of D127066765 so that this file, the only change in that stack under axel's open-source tree, is exported to facebookresearch/momentum on its own. Reviewed By: bschauerte Differential Revision: D127075307 fbshipit-source-id: 81fee7aa951aea1c73127efebc15a618f94c1464
1 parent 732ee66 commit c82e43f

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎axel/axel/BvhEmbree.cpp‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ void logEmbreeError(void* /*userPtr*/, RTCError err, const char* msg) {
4646
XR_LOGE("CANCELLED: {}", msg);
4747
break;
4848
}
49+
#if RTC_VERSION >= 40300
50+
case RTC_ERROR_LEVEL_ZERO_RAYTRACING_SUPPORT_MISSING: {
51+
XR_LOGE("LEVEL_ZERO_RAYTRACING_SUPPORT_MISSING: {}", msg);
52+
break;
53+
}
54+
#endif
4955
case RTC_ERROR_NONE: {
5056
break; // There's no error.
5157
}

0 commit comments

Comments
 (0)