Fix: setting FrameData.crop_bbox_xywh for backwards compatibility

shapovalov · facebook-github-bot · commit d0d0e020071c · 2024-07-16T02:21:13.000-07:00
Summary: This diff is fixing a backwards compatibility issue in PyTorch3D's dataset API. The code ensures that the `crop_bbox_xywh` attribute is set when box_crop flag is on. This is an implementation detail that people should not really use, however some people depend on this behaviour.

Reviewed By: bottler

Differential Revision: D59777449

fbshipit-source-id: b875e9eb909038b8629ccdade87661bb2c39d529
diff --git a/pytorch3d/implicitron/dataset/frame_data.py b/pytorch3d/implicitron/dataset/frame_data.py
@@ -276,6 +276,7 @@ def _crop_by_bbox_(
             image_size_hw=tuple(self.effective_image_size_hw),  # pyre-ignore
         )
         crop_bbox_xywh = bbox_xyxy_to_xywh(clamp_bbox_xyxy)
+        self.crop_bbox_xywh = crop_bbox_xywh
 
         if self.fg_probability is not None:
             self.fg_probability = crop_around_box(

Original file line number	Diff line number	Diff line change
`@@ -276,6 +276,7 @@ def _crop_by_bbox_(`
`276`	`276`	`image_size_hw=tuple(self.effective_image_size_hw), # pyre-ignore`
`277`	`277`	`)`
`278`	`278`	`crop_bbox_xywh = bbox_xyxy_to_xywh(clamp_bbox_xyxy)`
	`279`	`+ self.crop_bbox_xywh = crop_bbox_xywh`
`279`	`280`
`280`	`281`	`if self.fg_probability is not None:`
`281`	`282`	`self.fg_probability = crop_around_box(`