Skip to content

Add opengl camera conversion to utils, update camera_conversion_util to FoVPerspectiveCameras #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3a1b2c3 opened this issue Jan 4, 2023 · 2 comments

Comments

@3a1b2c3
Copy link

3a1b2c3 commented Jan 4, 2023

Add opengl camera conversion to utils, update camera_conversion_util,

Quite some people are struggling and come up with suboptimal solution. A lot of existing graphics code uses OpenGL conventions so its common
#294
#1199

Also camera_conversion_util could use FoVPerspectiveCameras instead of deprecated camera flavors https://github.com/facebookresearch/pytorch3d/blob/main/pytorch3d/utils/camera_conversions.py

@bottler
Copy link
Contributor

bottler commented Jan 4, 2023

I'm confused. The camera_conversions utils aims to convert to/from OpenGL conventions, and does not use deprecated camera flavors. Can you explain in more detail what you are trying to fix?

A conversion from FoVPerspectiveCameras in addition to what is currently present could make sense, is that it?

@3a1b2c3
Copy link
Author

3a1b2c3 commented Jan 4, 2023

The camera_conversions are to opencv opencv_from_cameras_projection() which is not opengl convention. Its a whole zoo and that is just y-up flavour :D
PerspectiveCameras says deprecated for me

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants