Skip to content

Pulsar Renderer: Support two focal lengths fx, fy. #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
axbycc-mark opened this issue Dec 9, 2024 · 2 comments
Closed

Pulsar Renderer: Support two focal lengths fx, fy. #1925

axbycc-mark opened this issue Dec 9, 2024 · 2 comments

Comments

@axbycc-mark
Copy link

axbycc-mark commented Dec 9, 2024

🚀 Feature

The Pulsar renderer is currently the fastest way to render pointclouds using pytorch3d. However, it only supports one focal length.

Motivation

It would be nice to support two focal lengths so that we can do inference with calibrated cameras from real life, which often have different fx and fy. This would enable some pose refinement / SLAM applications.

@bottler
Copy link
Contributor

bottler commented Dec 10, 2024

We aren't planning to work on this kind of thing soon. Even fixing and merging #1369 is not currently being worked on. Maybe you or someone else might do this?

@bottler bottler closed this as completed Dec 10, 2024
@axbycc-mark
Copy link
Author

Thanks. Can't work on that fix you mentioned currently, but for anyone else seeing this, here is a workaround.

Use the Pulsar renderer as an idealized virtual camera plane with some fixed focal length and size. Then the transform from the virtual camera plane to a focal-length corrected camera image is simply a homogeneous transform, which can be achieved by F.grid_sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants