Skip to content

feat(locale): add zh_CN food #3479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

yyz945947732
Copy link
Contributor

local zh_CN add food.

@yyz945947732 yyz945947732 requested a review from a team as a code owner April 15, 2025 03:54
Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit d992c82
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/68018503a5e5d40008f51632
😎 Deploy Preview https://deploy-preview-3479.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer changed the title feat(local): add local zh_CN food. feat(locale): add zh_CN food Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (04e4346) to head (d992c82).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3479    +/-   ##
========================================
  Coverage   99.97%   99.97%            
========================================
  Files        2838     2849    +11     
  Lines      218606   218992   +386     
  Branches      952      952            
========================================
+ Hits       218551   218939   +388     
+ Misses         55       53     -2     
Files with missing lines Coverage Δ
src/locales/zh_CN/food/adjective.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/food/description_pattern.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/food/dish.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/food/dish_pattern.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/food/ethnic_category.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/food/fruit.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/food/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/food/ingredient.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/food/meat.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/food/spice.ts 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92 Shinigami92 added c: locale Permutes locale definitions m: food Something is referring to the food module labels Apr 15, 2025
@Shinigami92 Shinigami92 added this to the vAnytime milestone Apr 15, 2025
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a tasty mix of different regional cuisines 😋

@xDivisionByZerox xDivisionByZerox added the p: 1-normal Nothing urgent label Apr 17, 2025
@xDivisionByZerox xDivisionByZerox merged commit 6c883e7 into faker-js:next Apr 17, 2025
24 checks passed
@xDivisionByZerox
Copy link
Member

Thank you for your contribution @yyz945947732 ❤️🙏
I see that this was your first contribution to our project.
Would you mind answering some questions regarding your contribution? This way we can understand the potential struggles or confusions new contributors might have when getting into the project. If you don't want to answer, please ignore this comment:

  1. What did motivate you to do your contribution?
  2. Did you read our documentation regarding contributing before starting to work on your contribution?
  3. How clear was the process of working on your contribution (before the PR) for you? Was there ever a time while working in the project where you didn't know what to do? If so how did you solve your problem?
  4. How clear was the process of the code review (PR) for you? Was there ever a time you felt unsure about the current situation?
  5. Anything else you'd like to share with the Faker team?

@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v9.x May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: food Something is referring to the food module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants