fix: Ensure nul-termination of string for inet_pton#1462
Merged
Conversation
zkat
approved these changes
May 8, 2026
This was referenced May 8, 2026
pull Bot
pushed a commit
to eduardomourar/js-compute-runtime
that referenced
this pull request
May 14, 2026
Co-authored-by: Kat Marchán <kzm@zkat.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inet_ptontakes a NUL-terminated string. We pass the data from astd::string_view, which is not guaranteed to be NUL-terminated. I believe that current calls will all involve NUL-terminated strings, so it shouldn't cause a problem right now in practice, but may do in the future.