fix: Find invalid characters after nul bytes in KV store keys#1464
Merged
Conversation
zkat
approved these changes
May 11, 2026
This was referenced May 11, 2026
pull Bot
pushed a commit
to eduardomourar/js-compute-runtime
that referenced
this pull request
May 14, 2026
…#1464) Co-authored-by: Kat Marchán <kzm@zkat.tech> Co-authored-by: Kat Marchán <kat.marchan@fastly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_invalid_character_for_kv_store_keytakes just achar*rather than ptr + length, so if the string contains NUL bytes, characters after the bytes are not checked. This PR adds a length parameter, a test, and also fixes a similar issue with relative paths later in the KV store code.