Skip to content
This repository was archived by the owner on Dec 20, 2023. It is now read-only.

Commit 8d5999d

Browse files
author
David Vrabel
committed
x86/xen: resume timer irqs early
If the timer irqs are resumed during device resume it is possible in certain circumstances for the resume to hang early on, before device interrupts are resumed. For an Ubuntu 14.04 PVHVM guest this would occur in ~0.5% of resume attempts. It is not entirely clear what is occuring the point of the hang but I think a task necessary for the resume calls schedule_timeout(), waiting for a timer interrupt (which never arrives). This failure may require specific tasks to be running on the other VCPUs to trigger (processes are not frozen during a suspend/resume if PREEMPT is disabled). Add IRQF_EARLY_RESUME to the timer interrupts so they are resumed in syscore_resume(). Signed-off-by: David Vrabel <[email protected]> Reviewed-by: Boris Ostrovsky <[email protected]> Cc: [email protected]
1 parent ac80c77 commit 8d5999d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/xen/time.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ void xen_setup_timer(int cpu)
444444

445445
irq = bind_virq_to_irqhandler(VIRQ_TIMER, cpu, xen_timer_interrupt,
446446
IRQF_PERCPU|IRQF_NOBALANCING|IRQF_TIMER|
447-
IRQF_FORCE_RESUME,
447+
IRQF_FORCE_RESUME|IRQF_EARLY_RESUME,
448448
name, NULL);
449449
(void)xen_set_irq_priority(irq, XEN_IRQ_PRIORITY_MAX);
450450

0 commit comments

Comments
 (0)