MSI-451: disabled sources tab content on manage_stock update

Author: Valeriy Nayda

app/code/Magento/InventoryCatalog/Ui/DataProvider/Product/Form/Modifier/SourceItems/ManageStock.php renamed to app/code/Magento/InventoryCatalog/Model/CanManageSourceItemsBySku.php

@@ -5,17 +5,17 @@
  */
 declare(strict_types=1);
 
-namespace Magento\InventoryCatalog\Ui\DataProvider\Product\Form\Modifier\SourceItems;
+namespace Magento\InventoryCatalog\Model;
 
 use Magento\CatalogInventory\Model\Configuration;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\InventoryCatalog\Api\DefaultStockProviderInterface;
 use Magento\InventoryConfigurationApi\Api\GetStockItemConfigurationInterface;
 
 /**
- * Check stock should be managed for given product sku.
+ * Check source items should be managed for given product sku
  */
-class ManageStock
+class CanManageSourceItemsBySku
 {
     /**
      * Provides manage stock global config value.
@@ -39,8 +39,6 @@ class ManageStock
     private $getStockItemConfiguration;
 
     /**
-     * ManageStock constructor.
-     *
      * @param ScopeConfigInterface $config
      * @param GetStockItemConfigurationInterface $getStockItemConfiguration
      * @param DefaultStockProviderInterface $defaultStockProvider
@@ -56,24 +54,21 @@ public function __construct(
     }
 
     /**
-     * Check, if stock should be managed for give product.
-     *
-     * @param string $sku
+     * @param string $sku Sku can be null if product is new
      * @return bool
-     * @throws \Magento\Framework\Exception\LocalizedException
      */
     public function execute(string $sku = null): bool
     {
-        $stockId = $this->defaultStockProvider->getId();
-        if ($sku) {
+        if (null !== $sku) {
+            $stockId = $this->defaultStockProvider->getId();
             $itemConfiguration = $this->getStockItemConfiguration->execute($sku, $stockId);
-            if ($itemConfiguration) {
+
+            if (null !== $itemConfiguration) {
                 return $itemConfiguration->isUseConfigManageStock()
                     ? (bool)$this->config->getValue(Configuration::XML_PATH_MANAGE_STOCK)
                     : $itemConfiguration->isManageStock();
             }
         }
-
         return (bool)$this->config->getValue(Configuration::XML_PATH_MANAGE_STOCK);
     }
 }

app/code/Magento/InventoryCatalog/Ui/DataProvider/Product/Form/Modifier/SourceItems.php

@@ -15,8 +15,8 @@
 use Magento\Inventory\Model\ResourceModel\SourceItem\CollectionFactory;
 use Magento\InventoryApi\Api\Data\SourceInterface;
 use Magento\InventoryApi\Api\Data\SourceItemInterface;
+use Magento\InventoryCatalog\Model\CanManageSourceItemsBySku;
 use Magento\InventoryCatalog\Model\IsSingleSourceModeInterface;
-use Magento\InventoryCatalog\Ui\DataProvider\Product\Form\Modifier\SourceItems\ManageStock;
 use Magento\InventoryConfiguration\Model\IsSourceItemsAllowedForProductTypeInterface;
 
 /**
@@ -50,34 +50,32 @@ class SourceItems extends AbstractModifier
     private $resourceConnection;
 
     /**
-     * Check, if stock should be managed for given product.
-     *
-     * @var ManageStock
+     * @var CanManageSourceItemsBySku
      */
-    private $manageStock;
+    private $canManageSourceItemsBySku;
 
     /**
      * @param IsSourceItemsAllowedForProductTypeInterface $isSourceItemsAllowedForProductType
      * @param IsSingleSourceModeInterface $isSingleSourceMode
      * @param LocatorInterface $locator
      * @param CollectionFactory $sourceItemCollectionFactory
      * @param ResourceConnection $resourceConnection
-     * @param ManageStock $manageStock
+     * @param CanManageSourceItemsBySku $canManageSourceItemsBySku
      */
     public function __construct(
         IsSourceItemsAllowedForProductTypeInterface $isSourceItemsAllowedForProductType,
         IsSingleSourceModeInterface $isSingleSourceMode,
         LocatorInterface $locator,
         CollectionFactory $sourceItemCollectionFactory,
         ResourceConnection $resourceConnection,
-        ManageStock $manageStock
+        CanManageSourceItemsBySku $canManageSourceItemsBySku
     ) {
         $this->isSourceItemsAllowedForProductType = $isSourceItemsAllowedForProductType;
         $this->isSingleSourceMode = $isSingleSourceMode;
         $this->locator = $locator;
         $this->sourceItemCollectionFactory = $sourceItemCollectionFactory;
         $this->resourceConnection = $resourceConnection;
-        $this->manageStock = $manageStock;
+        $this->canManageSourceItemsBySku = $canManageSourceItemsBySku;
     }
 
     /**
@@ -138,7 +136,8 @@ public function modifyMeta(array $meta)
             || $this->isSourceItemsAllowedForProductType->execute($product->getTypeId()) === false) {
             return $meta;
         }
-        $isMangeStock = $this->manageStock->execute($product->getSku());
+
+        $canMangeSourceItems = $this->canManageSourceItemsBySku->execute($product->getSku());
         $meta['sources'] = [
             'arguments' => [
                 'data' => [
@@ -154,7 +153,7 @@ public function modifyMeta(array $meta)
                             'arguments' => [
                                 'data' => [
                                     'config' => [
-                                        'visible' => $isMangeStock,
+                                        'visible' => $canMangeSourceItems,
                                     ],
                                 ],
                             ],
@@ -165,7 +164,7 @@ public function modifyMeta(array $meta)
                     'arguments' => [
                         'data' => [
                             'config' => [
-                                'visible' => $isMangeStock,
+                                'visible' => $canMangeSourceItems,
                             ],
                         ],
                     ],