Skip to content

Commit 3c41f94

Browse files
tpvasconcelosachalspyalexadchiafelixwang9817
authored
feat: Make feast PEP 561 compliant (#2405)
* add py.typed marker Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * add py.typed to MANIFEST.in Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * ignore mypy error from generated protos modules Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * revert: ignore mypy error from generated protos modules Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * reorder imports Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * sort imports Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * sort imports Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * feat: Allow using entity's join_key in get_online_features (#2420) * allowing using entity's join_key in get_online_features Signed-off-by: pyalex <[email protected]> * fix tests Signed-off-by: pyalex <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * fix!: GetOnlineFeatureResponse in Python feature server should be consisten… (#2418) * GetOnlineFeatureResponse in Python feature server should be consistent with Java implementation Signed-off-by: pyalex <[email protected]> * fix local e2e test Signed-off-by: pyalex <[email protected]> * reuse timestamp in response generation Signed-off-by: pyalex <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * chore: Adding documentation on community calendar + newsletter + updating CONTRIBUTING.md (#2425) * chore: Adding documentation on community calendar + newsletter and cross linking more on how to contribute to Feast Signed-off-by: Danny Chiao <[email protected]> * fix PR template Signed-off-by: Danny Chiao <[email protected]> * fix PR template Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * feat: Graduate write_to_online_store out of experimental status (#2426) Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * refactor!: Remove deprecated parameters from Entity and FeatureView (#2427) * Remove labels parameter from Entity Signed-off-by: Felix Wang <[email protected]> * Remove input parameter and deprecate Duration type for ttl parameter in FeatureView Signed-off-by: Felix Wang <[email protected]> * Change examples to stop using Duration Signed-off-by: Felix Wang <[email protected]> * Delete unused example feature repo Signed-off-by: Felix Wang <[email protected]> * Format Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * ci: Modify release script to only do minor release for breaking changes (#2431) Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * fix: Ensure that __init__ files exist in proto dirs (#2433) Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * feat: Allow using entity's join_key in get_online_features (#2420) * allowing using entity's join_key in get_online_features Signed-off-by: pyalex <[email protected]> * fix tests Signed-off-by: pyalex <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * fix!: GetOnlineFeatureResponse in Python feature server should be consisten… (#2418) * GetOnlineFeatureResponse in Python feature server should be consistent with Java implementation Signed-off-by: pyalex <[email protected]> * fix local e2e test Signed-off-by: pyalex <[email protected]> * reuse timestamp in response generation Signed-off-by: pyalex <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * chore: Adding documentation on community calendar + newsletter + updating CONTRIBUTING.md (#2425) * chore: Adding documentation on community calendar + newsletter and cross linking more on how to contribute to Feast Signed-off-by: Danny Chiao <[email protected]> * fix PR template Signed-off-by: Danny Chiao <[email protected]> * fix PR template Signed-off-by: Danny Chiao <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * feat: Graduate write_to_online_store out of experimental status (#2426) Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * refactor!: Remove deprecated parameters from Entity and FeatureView (#2427) * Remove labels parameter from Entity Signed-off-by: Felix Wang <[email protected]> * Remove input parameter and deprecate Duration type for ttl parameter in FeatureView Signed-off-by: Felix Wang <[email protected]> * Change examples to stop using Duration Signed-off-by: Felix Wang <[email protected]> * Delete unused example feature repo Signed-off-by: Felix Wang <[email protected]> * Format Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * ci: Modify release script to only do minor release for breaking changes (#2431) Signed-off-by: Felix Wang <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> * fix: Ensure that __init__ files exist in proto dirs (#2433) Signed-off-by: Achal Shah <[email protected]> Signed-off-by: Tomas Pereira de Vasconcelos <[email protected]> Co-authored-by: Achal Shah <[email protected]> Co-authored-by: Oleksii Moskalenko <[email protected]> Co-authored-by: Danny Chiao <[email protected]> Co-authored-by: Felix Wang <[email protected]>
1 parent e14369d commit 3c41f94

File tree

4 files changed

+4
-2
lines changed

4 files changed

+4
-2
lines changed

‎Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ format-python:
9292
cd ${ROOT_DIR}/sdk/python; python -m black --target-version py37 feast tests
9393

9494
lint-python:
95-
cd ${ROOT_DIR}/sdk/python; python -m mypy feast/ tests/
95+
cd ${ROOT_DIR}/sdk/python; python -m mypy
9696
cd ${ROOT_DIR}/sdk/python; python -m isort feast/ tests/ --check-only
9797
cd ${ROOT_DIR}/sdk/python; python -m flake8 feast/ tests/
9898
cd ${ROOT_DIR}/sdk/python; python -m black --check feast tests

‎sdk/python/MANIFEST.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
recursive-include feast/protos/ *.py
22
include feast/binaries/*
3+
recursive-include feast py.typed *.pyi

‎sdk/python/feast/py.typed

Whitespace-only changes.

‎sdk/python/setup.cfg

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
[isort]
2+
src_paths = feast,tests
23
multi_line_output=3
34
include_trailing_comma=True
45
force_grid_wrap=0
@@ -16,5 +17,5 @@ select = B,C,E,F,W,T4
1617
exclude = .git,__pycache__,docs/conf.py,dist,feast/protos
1718

1819
[mypy]
19-
files=feast,test
20+
files=feast,tests
2021
ignore_missing_imports=true

0 commit comments

Comments
 (0)