You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First off, great work! I am using your extension during daily development and it works very well.
A feature still missing is global symbol search. (ctrll+p, #)
I started working on a feature branch and it already does the job.
Parsing the whole php-language-server project takes about 10 seconds on my machine.
The php-cli process takes up about 180MB of ram with all symbol information parsed.
Changes made:
Added support for client:window/* commands
Added support for server:workspace/* commands
Refactored symbol database into own set of classes. (Was in Server/TextDocument before)
Disabled memory limit
ProtocolStreamReader was blocking the event loop, made non-blocking
Find all .php files on startup and start parsing one at a time with Loop/nextTick
To do:
Fix old tests
Add new tests
Reduce memory usage. Most of it is the AST, maybe we can throw it away after parsing,
Wow, nice work! I really like the refactor into separate classes. I would encourage you to open the PR right because then I can make comments there (you can still add stuff to the branch)
First off, great work! I am using your extension during daily development and it works very well.
A feature still missing is global symbol search. (ctrll+p, #)
I started working on a feature branch and it already does the job.
Parsing the whole php-language-server project takes about 10 seconds on my machine.
The php-cli process takes up about 180MB of ram with all symbol information parsed.
Changes made:
To do:
Please let me know what you think about it and if you want any changes made. I can then open a pull request.
The text was updated successfully, but these errors were encountered: