Skip to content

Commit 2c059c9

Browse files
authored
Merge branch 'master' into sabre/event-5.0.3-#166.1.0
2 parents dd796fd + 21d79b5 commit 2c059c9

File tree

4 files changed

+66
-16
lines changed

4 files changed

+66
-16
lines changed

README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,11 @@ I recommend to disable VS Code's built-in PHP IntelliSense by setting `php.sugge
4040
### Column-accurate error reporting
4141
![Error reporting demo](images/publishDiagnostics.png)
4242

43-
### Format code
43+
### Code style linting
4444
Please use a dedicated extension like [PHP CodeSniffer](https://marketplace.visualstudio.com/items?itemName=ikappas.phpcs).
4545

46+
### Format code
47+
Please use a dedicated extension like [PHP CS Fixer](https://marketplace.visualstudio.com/items?itemName=junstyle.php-cs-fixer).
4648

4749
## Todo
4850
- Rename
@@ -54,7 +56,7 @@ Clone whole repository and in root directory execute:
5456
```bash
5557
composer install
5658
npm install
57-
npm run compile
59+
npm run build
5860
code .
5961
```
6062
The last command will open the folder in VS Code. Hit `F5` to launch an Extension Development Host with the extension.

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"minimum-stability": "dev",
33
"prefer-stable": true,
44
"require": {
5-
"felixfbecker/language-server": "v5.3.7"
5+
"felixfbecker/language-server": "v5.4.0"
66
},
77
"scripts": {
88
"parse-stubs": "LanguageServer\\ComposerScripts::parseStubs",

composer.lock

Lines changed: 57 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/extension.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,10 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
9393
// Options to control the language client
9494
const clientOptions: LanguageClientOptions = {
9595
// Register the server for php documents
96-
documentSelector: ['php'],
96+
documentSelector: [
97+
{ scheme: 'file', language: 'php' },
98+
{ scheme: 'untitled', language: 'php' }
99+
],
97100
uriConverters: {
98101
// VS Code by default %-encodes even the colon after the drive letter
99102
// NodeJS handles it much better

0 commit comments

Comments
 (0)