fix: fix parser ending properly

Author: fent

lib/feedme.js

@@ -54,6 +54,14 @@ module.exports = class FeedMe extends Writable {
     this._parser.write(data, encoding, callback);
   }
 
+  _final(callback) {
+    if (this._parser) {
+      this._parser.end(callback);
+    } else {
+      callback(null);
+    }
+  }
+
   done() {
     return this._parser.done();
   }

lib/jsonfeedparser.js

@@ -154,6 +154,11 @@ module.exports = class JSONFeedParser extends Writable {
     callback(null);
   }
 
+  _final(callback) {
+    this.parser.end();
+    callback(null);
+  }
+
   done() {
     if (!this._buffer) { return; }
     let root = this._currObj[this._currKey];

lib/xmlfeedparser.js

@@ -168,6 +168,11 @@ module.exports = class XMLFeedParser extends Writable {
     callback(null);
   }
 
+  _final(callback) {
+    this.parser.end();
+    callback(null);
+  }
+
   // Called when done parsing the document.
   // Returns entire document in object form.
   done() {

test/assets/badfeed.xml

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<uhoh<<<<

test/bad-test.js

@@ -39,3 +39,15 @@ describe('Parse a feed with no items', () => {
     fs.createReadStream(file).pipe(parser);
   });
 });
+
+describe('Parse a badly formatted feed', () => {
+  it('Parser gives an error', (done) => {
+    const file = path.join(__dirname, 'assets', 'badfeed.xml');
+    const parser = new FeedMe();
+    parser.on('error', (err) => {
+      assert.ok(/Unexpected end/.test(err.message), `Error message: ${err.message}`);
+      done();
+    });
+    fs.createReadStream(file).pipe(parser);
+  });
+});