FEVM | Eth Compliance Test | Hit with "Execution Freeze"

[shamb0]

Under WASM RT context, list of Use-cases Hit with “Execution Freeze”.

Test ID	Use-Case	Trace
TID-03-01	"stAttackTest/ContractCreationSpam"	Trace
TID-58-52	vmPerformance::loopMul	Trace

[Stebalien]

I'm not able to repro this after applying shamb0/fevm-eth-compliance-test#1. I get:

   Compiling evm_eth_compliance v10.0.0-alpha.1 (/home/steb/src/github.com/shamb0/fevm-eth-compliance-test)
    Finished dev [unoptimized + debuginfo] target(s) in 12.09s
     Running `target/debug/evm_eth_compliance statetest`
2023-01-23T01:36:27.010631Z  INFO evm_eth_compliance::statetest::cmd: Start running tests on: Path :: "test-vectors/tests/GeneralStateTests/stAttackTest/ContractCreationSpam.json", Total Files :: 1
2023-01-23T01:36:27.011303Z TRACE evm_eth_compliance::statetest::runner: Calling testfile => "test-vectors/tests/GeneralStateTests/stAttackTest/ContractCreationSpam.json"
2023-01-23T01:36:27.100640Z  INFO evm_eth_compliance::statetest::runner: Pre-Block Iteration :: 0
2023-01-23T01:36:27.105356Z  INFO evm_eth_compliance::statetest::runner: New State ID Updated
2023-01-23T01:36:27.105375Z  INFO evm_eth_compliance::statetest::runner: Pre-Block Iteration :: 1
2023-01-23T01:36:27.106204Z  INFO evm_eth_compliance::statetest::runner: New State ID Updated
2023-01-23T01:36:27.107191Z  INFO evm_eth_compliance::statetest::runner: Entering Post Block => Istanbul 0
2023-01-23T01:36:27.107242Z  WARN evm_eth_compliance::statetest::runner: Skipping Post Test test_name: '"ContractCreationSpam"', chain_spec: 'Istanbul', data_index: 0
2023-01-23T01:36:27.107252Z  INFO evm_eth_compliance::statetest::runner: Entering Post Block => Berlin 0
2023-01-23T01:36:27.107259Z  WARN evm_eth_compliance::statetest::runner: Skipping Post Test test_name: '"ContractCreationSpam"', chain_spec: 'Berlin', data_index: 0
2023-01-23T01:36:27.107265Z  INFO evm_eth_compliance::statetest::runner: Entering Post Block => London 0
2023-01-23T01:36:27.107272Z  WARN evm_eth_compliance::statetest::runner: Skipping Post Test test_name: '"ContractCreationSpam"', chain_spec: 'London', data_index: 0
2023-01-23T01:36:27.107281Z  INFO evm_eth_compliance::statetest::runner: Entering Post Block => Merge 0
2023-01-23T01:36:27.107287Z  WARN evm_eth_compliance::statetest::runner: Skipping Post Test test_name: '"ContractCreationSpam"', chain_spec: 'Merge', data_index: 0
2023-01-23T01:36:27.109297Z TRACE evm_eth_compliance::statetest::runner: TestDone => "test-vectors/tests/GeneralStateTests/stAttackTest/ContractCreationSpam.json"
█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████ 1/12023-01-23T01:36:27.109880Z  INFO evm_eth_compliance::statetest::runner: Finished Processing of 1 Files in Time:6.677916ms

[shamb0]

For me no luck, I can see change in trace prints with Patch, but still execution is frozen.

One more observation is, the Use-case trying to drain out the system resources. 78% cpu is consumed & only 1.4GB of Ram is left.

After Launching the Use-Case

Average system load

Execution Trace are updated.

[Stebalien]

Hm. Yes, I see that now, I'm not sure why it worked before.

The issue is that this test is designed to run out of gas, but you're giving the test 99 quadrillion gas, where the most Filecoin supports is 10B.

Or, at least, I assume that's what this is trying to test.

[shamb0]

Indeed I executed testsuite with Max Gaslimit
to overcome SYS_OUT_OF_GAS error, for other testsuites.

• May I know how ref-fvm gas metering is calibrated for fevm ?
  are they one-to-one same with Eth EVM ?

• For example if we take GeneralStateTests/stAttackTest/ContractCreationSpam.json,
  provided gaslimit is in 10000000 gwei unit (0x989680).

"transaction" : {
	"data" : [
		"0x"
	],
	"gasLimit" : [
		"0x989680"
	],
	"gasPrice" : "0x0a",
	"nonce" : "0x00",
	"secretKey" : "0x45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8",
	"sender" : "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b",
	"to" : "0x6a0a0fc761c612c340a0e98d33b37a75e5268472",
	"value" : [
		"0x00"
	]
}

• When passing Message to ref-fvm, we have below two possibilities.
  may I know which one to choose ?

fun()	Values
Gas::new(tx_gas_limit).as_milligas()	10000000 * 1000 gas unit
Gas::from_milligas(tx_gas_limit).as_milligas()	10000000 gas unit

// Send message
let message = Message {
	from: sender_account.unwrap().1,
	to: actor_address,
	sequence: sender_state.sequence,
	gas_limit: Gas::from_milligas(tx_gas_limit).as_milligas(),
	method_num: fil_actor_evm::Method::InvokeContract as u64,
	params: raw_params,
	..Message::default()
};

[Stebalien]

May I know how ref-fvm gas metering is calibrated for fevm ?
are they one-to-one same with Eth EVM ?

The maximum gas an FVM message can take is 10e9 (10B).

There isn't an accurate gas ratio, unfortunately.

• If a test tries to assert that some operation will complete within some amount of gas, that test won't work in the FVM.
• If a test (like this one) just wants to make sure some operation runs out of gas before it runs out of memory, use a 10B gas limit.

When passing Message to ref-fvm, we have below two possibilities.
may I know which one to choose ?

Always pass gas, never milligas. Milligas is used internally only so we can charge fractional gas (in a few places), but gas values on messages and receipts is always in full gas units.

[shamb0]

Fine, used gas_limit without any transformation. and Hit with error SYS_OUT_OF_GAS(ExitCode::7) as expected. Link to complete Trace

      // Send message
      let message = Message {
          from: sender_account.unwrap().1,
          to: actor_address,
          sequence: sender_state.sequence,
          gas_limit: tx_gas_limit,
          method_num: fil_actor_evm::Method::InvokeContract as u64,
          params: raw_params,
          ..Message::default()
      };

Finished Processing of 1 Files in Time:721.748566ms
=== Start ===
=== OK Status ===
None
=== KO Status ===
Count :: 1
{
    "ContractCreationSpam.json::ContractCreationSpam": [
        "Istanbul | 0 | ExitCode { value: 7 }",
        "Berlin | 0 | ExitCode { value: 7 }",
        "London | 0 | ExitCode { value: 7 }",
        "Merge | 0 | ExitCode { value: 7 }",
    ],
}
=== SKIP Status ===
None
=== End ===

[shamb0]

• Verified Execution of TID-58-52 :: vmPerformance::loopMul. looks OK.
• Takes too long to complete (506 sec). Better to have review on gas consumed for each use-cases. Link to complete trace

INFO evm_eth_compliance::statetest::runner: Finished Processing of 1 Files in Time:506.150602693s
=== Start ===
=== OK Status ===
Count :: 1
{
    "loopMul.json::loopMul": [
        "Istanbul | 0 | ExitCode { value: 0 }",
        "Istanbul | 1 | ExitCode { value: 0 }",
        "Istanbul | 2 | ExitCode { value: 0 }",
        "Berlin | 0 | ExitCode { value: 0 }",
        "Berlin | 1 | ExitCode { value: 0 }",
        "Berlin | 2 | ExitCode { value: 0 }",
        "London | 0 | ExitCode { value: 0 }",
        "London | 1 | ExitCode { value: 0 }",
        "London | 2 | ExitCode { value: 0 }",
        "Merge | 0 | ExitCode { value: 0 }",
        "Merge | 1 | ExitCode { value: 0 }",
        "Merge | 2 | ExitCode { value: 0 }",
    ],
}
=== KO Status ===
None
=== SKIP Status ===
None
=== End ===