Skip to content

Fix: "publish to single file"-feature not working on .NET Core 3.1 or higher#529

Merged
filipw merged 4 commits into
dotnet-script:masterfrom
DanielEgbers:feature/PublishSingleFile-netcoreapp3.1-fix
Mar 30, 2020
Merged

Fix: "publish to single file"-feature not working on .NET Core 3.1 or higher#529
filipw merged 4 commits into
dotnet-script:masterfrom
DanielEgbers:feature/PublishSingleFile-netcoreapp3.1-fix

Conversation

@DanielEgbers

Copy link
Copy Markdown

The latest release 0.51.0 added the "publish to single file"-feature (#496), but it only works with .NET Core 3.0.

This pull request enables PublishSingleFile on all .NET Core Version equal or greater than 3.0.

Additional future proof changes:

  • ScriptEnvironment.GetNetCoreAppVersion handling .NET Core Version-Numbers with more than one digit
  • ScriptDependencyContextReader.ReadDependencyContext handling .NET Core Versions greater than 3

@filipw filipw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh this is a bit unfortunate, thanks!

@seesharper seesharper left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@filipw filipw merged commit 75f1f05 into dotnet-script:master Mar 30, 2020
@DanielEgbers DanielEgbers deleted the feature/PublishSingleFile-netcoreapp3.1-fix branch April 5, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants