Review comments

rikoe · rikoe · commit 17cec0256bcd · 2020-02-13T10:58:51.000Z
- remove FDS_ID from contact
- make holding mandatory on position
diff --git a/src/context/schemas/contact.schema.json b/src/context/schemas/contact.schema.json
@@ -8,8 +8,7 @@
     "id": {
       "type": "object",
       "properties": {
-        "email": { "type": "string" },
-        "FDS_ID": { "type": "string" }
+        "email": { "type": "string" }
       }
     }
   },
diff --git a/src/context/schemas/position.schema.json b/src/context/schemas/position.schema.json
@@ -8,5 +8,5 @@
     "instrument": { "$ref": "instrument.schema#/" },
     "holding": { "type": "number", "minimum": 0 }
   },
-  "required": ["instrument"]
+  "required": ["instrument","holding"]
 }
diff --git a/website/static/schemas/next/contact.schema.json b/website/static/schemas/next/contact.schema.json
@@ -8,8 +8,7 @@
     "id": {
       "type": "object",
       "properties": {
-        "email": { "type": "string" },
-        "FDS_ID": { "type": "string" }
+        "email": { "type": "string" }
       }
     }
   },
diff --git a/website/static/schemas/next/position.schema.json b/website/static/schemas/next/position.schema.json
@@ -8,5 +8,5 @@
     "instrument": { "$ref": "instrument.schema#/" },
     "holding": { "type": "number", "minimum": 0 }
   },
-  "required": ["instrument"]
+  "required": ["instrument","holding"]
 }

Original file line number	Diff line number	Diff line change
`@@ -8,5 +8,5 @@`
`8`	`8`	`"instrument": { "$ref": "instrument.schema#/" },`
`9`	`9`	`"holding": { "type": "number", "minimum": 0 }`
`10`	`10`	`},`
`11`		`- "required": ["instrument"]`
	`11`	`+ "required": ["instrument","holding"]`
`12`	`12`	`}`