fix windows CI

Author: timbess

.github/workflows/build.yaml

@@ -132,8 +132,8 @@ jobs:
             fail-fast: false
             matrix:
                 os:
-                    - ubuntu-22.04
-                    - macos-13
+                    # - ubuntu-22.04
+                    # - macos-13
                     - windows-2022
                 arch:
                     - aarch64
@@ -149,6 +149,14 @@ jobs:
                       arch: aarch64
 
         steps:
+            # - name: Enable longpath
+            #   run: |
+            #       New-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Control\FileSystem" -Name "LongPathsEnabled" -Value 1 -PropertyType DWORD -Force
+            #       New-Item -Path 'HKLM:\SOFTWARE\Microsoft\Command Processor' -Name 'DisableUNCCheck' -Force
+            #       Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Command Processor' -Name 'DisableUNCCheck' -Type DWord -Value 1
+            #       gpupdate /force
+            #   if: ${{ contains(matrix.os, 'windows') }}
+
             - name: Checkout
               uses: actions/checkout@v4
 
@@ -173,7 +181,35 @@ jobs:
 
             - name: Python Build
               run: pnpm run build
+              if: ${{ !contains(matrix.os, 'windows') }}
+              env:
+                  # CARGO_TARGET_DIR: \\?\D:\psp-rust
+                  # CARGO_TARGET_DIR: \\?\D:\${{ github.workspace }}\target
+                  VCPKG_ROOT: ${{ steps.init-step.outputs.VCPKG_INSTALLATION_ROOT }}
+                  PACKAGE: "perspective-python"
+                  PSP_USE_CCACHE: 1
+                  PSP_ARCH: ${{ matrix.arch }}
+                  CI: 1
+
+            - name: Python Build Pyodide
+              run: pnpm run build
+              if: ${{ contains(matrix.os, 'ubuntu') }}
+              env:
+                  PSP_PYODIDE: 1
+                  PACKAGE: "perspective-python"
+                  PSP_USE_CCACHE: 1
+                  CI: 1
+
+            - name: Python Build (Windows)
+              run: |
+                  New-Item -ItemType Directory -Path $env:CARGO_TARGET_DIR -Force
+                  pnpm run build
+              if: ${{ contains(matrix.os, 'windows') }}
+              # working-directory: \\?\${{github.workspace}}
               env:
+                  CARGO_TARGET_DIR: D:\psp-rust
+                  PSP_ROOT_DIR: ${{ github.workspace }}
+                  # CARGO_TARGET_DIR: \\?\${{ github.workspace }}\target
                   VCPKG_ROOT: ${{ steps.init-step.outputs.VCPKG_INSTALLATION_ROOT }}
                   PACKAGE: "perspective-python"
                   PSP_USE_CCACHE: 1

Cargo.lock

@@ -51,6 +51,7 @@ cmake = "0.1.50"
 num_cpus = "1.16.0"
 pyo3-build-config = "0.20.2"
 python-config-rs = "0.1.2"
+tempfile = "3.10.1"
 
 [dependencies]
 async-lock = "2.5.0"

rust/perspective-python/Cargo.toml

@@ -23,11 +23,14 @@ const { emscripten } = JSON.parse(
     fs.readFileSync(sh.path`${__dirname}/../../package.json`)
 );
 
-const cmd = sh(process.argv.slice(2).join(" "));
+const cmd = sh();
 
-cmd.env({
-    PSP_ROOT_DIR: "../..",
-});
+// if not windows
+if (process.platform !== "win32") {
+    cmd.env({
+        PSP_ROOT_DIR: "../..",
+    });
+}
 
 if (is_pyodide) {
     cmd.sh`. ${emsdkdir}/emsdk_env.sh >/dev/null 2>&1`
@@ -67,7 +70,8 @@ function get_host_triple() {
 }
 
 cmd.sh(
-    `maturin ${maturin_command} --features=external-cpp --sdist ${maturin_flags}`
+    `maturin ${maturin_command} --features=external-cpp --verbose ${maturin_flags}`
 );
 
-await cmd();
+console.log("RUNNING_CMD: ", cmd.toString());
+cmd.runSync();

rust/perspective-python/build.js

@@ -54,6 +54,10 @@ pub fn cmake_build() -> Result<PathBuf, std::io::Error> {
     }
 
     let mut dst = Config::new("cpp/perspective");
+    if cfg!(windows) {
+        std::fs::create_dir_all("D:\\psp-build")?;
+        dst.out_dir("D:\\psp-build");
+    }
     let profile = std::env::var("PROFILE").unwrap();
     dst.always_configure(true);
     dst.define("CMAKE_BUILD_TYPE", profile.as_str());

rust/perspective-python/build.mjs

@@ -41,6 +41,7 @@ export-cpp-only = []
 cxx-build = "1.0.115"
 cmake = "0.1.50"
 num_cpus = "1.16.0"
+tempfile = "3.10.1"
 
 [dependencies]
 async-lock = "2.5.0"

rust/perspective-python/build/psp.rs

@@ -54,6 +54,10 @@ pub fn cmake_build() -> Result<PathBuf, std::io::Error> {
     }
 
     let mut dst = Config::new("cpp/perspective");
+    if cfg!(windows) {
+        std::fs::create_dir_all("D:\\psp-build")?;
+        dst.out_dir("D:\\psp-build");
+    }
     let profile = std::env::var("PROFILE").unwrap();
     dst.always_configure(true);
     dst.define("CMAKE_BUILD_TYPE", profile.as_str());