Update Python benchmarks to include results for update calls#1011
Merged
Update Python benchmarks to include results for update calls#1011
update calls#1011Conversation
timkpaine
approved these changes
Apr 11, 2020
sc1f
force-pushed
the
py-benchmark-updates
branch
from
ab0ae67 to
89d70d6
Compare
Member
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the Python benchmarks by adding tests for calls to
update, which is now benchmarked for both JSON andpandas.DataFramewhen 10 views of various pivots are created and forced to be notified on each update. The benchmark measures the amount of time it takes to callupdateand thenTable.size(), which forces processing of the update before returning a value.