Fix path resolution for cross-origin assets#1141
Merged
Conversation
Member
Author
|
Thanks @sc1f for discovering the root cause for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Perspective's cross-origin Web Worker and Wasm loading logic to use
document.currentScript. In the before times, the long-long ago, we supported a browser called Internet Explorer 8, which led to some highly questionable logic for determining the path of these assets, throwing anErrorand parsing the stack trace ...I expect this will fix issues #1139 and possibly #1128 - but I can't say for sure until 0.5.3 is released, as the specific interplay of this issue was only detected due to how
unpkg.comresolvesbrowseralias fields inpackage.json.