GIL release for perspective-python Async mode#1198
Merged
Conversation
c4e1247 to
16dee7c
Compare
sc1f
approved these changes
Sep 19, 2020
Contributor
sc1f
left a comment
There was a problem hiding this comment.
Looks good! Tested locally & offline and enables some really great parallel performance over large datasets.
16dee7c to
9404181
Compare
9404181 to
18d55a6
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
set_loop_callback()public method to thePerspectiveManagerclass, which takes as an argument a loop-queueing function, such as asynciocall_soon()and Tornadoadd_callback(). Once invoked, Perspective will presume to be owned by the calling thread, and will release the Python GIL for the bulk of reading/writing Apache Arrow data, as well as calculatingnew
Viewcontexts. There are some new restrictions in this mode, namely that Perspective is no longer thread safe, covered in the documentation.