Conversation
|
Thank you for your contribution and Welcome to our Open Source Community! To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement. Having reviewed our contributor list, we require a CLA for the following people : (@Sam-Ogden). If you need help obtaining a CLA, please read the Requirements for Contributions section of our CLA wiki or email help@finos.org with your questions. Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. cc @finos-admin |
sc1f
left a comment
There was a problem hiding this comment.
Tested locally - looks great, works well for arbitrary pivots and filters. Thanks!
|
Came across this while facing a problem with click. The click event is not being raised. Used the below code from the [documentation)(https://perspective.finos.org/docs/md/js.html), but event is not getting triggered. Then came across this PR. Wondering if the |
|
Thanks for the PR! Apologies for the delay in merging, this is a much-requested feature addition. Following the pattern of existing const viewer = document.querySelector("perspective-viewer");
const table = document.querySelector("perspective-viewer regular-table");
viewer.addEventListener(x => {
console.log(table.getMeta(x.target));
});As it stands however, this is not particularly useful for a few reasons:
For the latter at least, I propose |
Fixes #1076
This PR adds the perspective-click event to perspective-viewer-datagrid as specified in the docs.