Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the
regular-tabledependency to0.2.1from0.1.5changelog, mainly adding support for incremental rendering and theinvalidate()API for dimension-altering styles.In implementing the change, I've also pulled the source from
perspective.mdinto@finos/perspective-viewer-datagirddirectly and simplified it a bit to trade performance for readability. I've also moved the style callbacks to useperspective.config.js- this will add back formatting support for types but not yet custom types (ala #1301), which I'll have to fix in a future PR when we figure out how to unify formatting between JavaScript and Python.