Conversation
…ake methods on psp_widget async
timkpaine
approved these changes
Jul 2, 2021
| maxAssetSize: 512000 | ||
| }, | ||
| externals: [/^([a-z0-9]|@(?!finos\/perspective-viewer))/], | ||
| externals: [/\@jupyter|\@lumino/], |
Member
There was a problem hiding this comment.
Should this include jupyter widgets external?
Contributor
|
Super keen to get this released so I can get my hands on the voila fixes! 🚀 |
Member
|
Thanks for the PR! A couple post-review notes:
|
Contributor
|
Unfortunately I can't help with the development or packaging but I'm happy to test the JupyterLab/Voila combo on our deployment and report back any issues... |
Contributor
Author
|
I have just tested the 0.10.0 release in a fresh virtualenv with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
perspective-jupyterlabbuild to inline its external dependencies on the main Perspective modules, and makes some long-overdue improvements toPerspectiveWidgetin order to enhance the user experience in Jupyterlab and Voila. Specifically:PerspectiveWidgethad a height of 0 when rendered inside Voila. The height now defaults to 520px, the same as in Jupyterlab.<perspective-viewer>config panel now shows by default on all widgets when rendered.worker.terminate()andviewer.delete()is now called whenever the widget output is disposed of, which should make memory usage in Jupyterlab more efficient.PerspectiveWidgetnow inherits fromipywidgets.DOMWidgetinstead ofipywidgets.Widget, which means thatlayoutshould work out of the box:plugin_configcan now be passed in from Python, which should allow for much finer-grained control over styling of the datagrid and chart plugins. However, becauseplugin_configcannot be read synchronously from the Javascript front-end (as it is not part of the attribute API and there is no asyncgetin Javascript), there is currently no way to read the currentplugin_configfrom the widget unless it has been set by the user already. However, this is still very useful for developers to "pre-set" styles onPerspectiveWidget:WebSocketServerto strip out semver-like ranges from requests. This is helpful when debugging Voila locally, as I can just set the Voila CDN tolocalhost:8080/node_modules/and all the CDN requests Voila makes will automatically be resolved against my local build.