Merged
Conversation
0b6b2ba to
5aae70d
Compare
5eca4a8 to
fcbefb0
Compare
Merged
75ce153 to
96f424a
Compare
101af7e to
1efc1a3
Compare
13d06ad to
747bdf5
Compare
747bdf5 to
fe14b70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the
@finos/perspective-viewerpackages entirely, replacing it with previously internal@finos/perspective-vieuxpackage, which has been renamed to the former. This is mostly a drop-in replacement, but some APIs have been cleaned up in the process:The HTML Attribute API for
<perspective-viewer>has been mostly deprecated. Some attributes which are inert but read by plugins currently remain:editable,selectableandname. For all other attributes, userestore()instead, whichpluginandcolumnsare set, without overwritingcolumnswith theplugin's defaults.await-ed, when you need to perform an action after a field's effects have rendered.Semantics for
restore()have also been updated slightly. A field can be explicitly ignored by omitting the field entirely from the restore object, and explicitly set to default by setting it toundefined. As a result, callingview.restore({})has no effect now (all fields are omitted/ignored), where-as previous versions this call was equivalent toreset().New MessagePack based serialization options for
save()andrestore().save()andrestore()now support thesettingsflag to set User Settings visibility. Fixes toggleConfig() via attribute and part of save() (for perspective-viewer) #879Test suite has been rewritten. Screenshots are no longer hashed, these tests now compare DOM fragments from the rendered page instead, only generating a screenshot when the test fails. As a result,
dockeris no longer needed for JS tests and has been removed, and test suite runs substantially faster on OSX.New UX features:
In-place editing of expression columns, as well as expression delete button.
Drag/drop dragimage is now centered in the top/left (previously it was anchored to dragstart click position), and is clipped to the column name and type badge only.
Drag/drop columns in the header (
Group By,Sort, etc) can now accept drop columns in any position instead of just the end of the list.Filter auto-complete now shows all completions from the dataset (instead of just the top 10), has an
:emptystyle, and initializes in a pre-filtered state correctly.Numeric filters now use
<input type="number">, Date filters use<input type="date">. DateTime filters additionally use<input type="time">