Fix #1566, remove deprecated flags from WASM debug build#1567
Merged
Conversation
timkpaine
approved these changes
Oct 5, 2021
texodus
approved these changes
Oct 6, 2021
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes server mode Python by fixing the output of
validate_expressions, which was missing a field in the Python implementation. In the pre-1.0.0 viewer,expression_aliaswas a map of expression aliases to the whole expression string so the user could hover over a column in the UI and see the expression from whence it came. With the "edit expression" button added in 1.0.0, it is no longer necessary to see the whole expression separate from the editor.Even though the
expression_aliasfield is not used in the viewer, it is required and type-checked by Rust and thus threw an unrecoverable error when loading the table from Python. The long-term fix is to move all validation and parsing logic for expressions, along with other logic that is implemented twice in both JS and Python, all into C++.Additionally, the WASM debug build was outputting deprecated flag warnings, which have been rectified.