Skip to content

bump windows build for vc 14.2 / vs 16 2019, add macos 11 build for py3.9#1626

Merged
texodus merged 6 commits intoperspective-dev:masterfrom
timkpaine:tkp/windows
Nov 23, 2021
Merged

bump windows build for vc 14.2 / vs 16 2019, add macos 11 build for py3.9#1626
texodus merged 6 commits intoperspective-dev:masterfrom
timkpaine:tkp/windows

Conversation

@timkpaine
Copy link
Member

fixes #1601

@timkpaine timkpaine marked this pull request as ready for review November 23, 2021 02:49
@timkpaine timkpaine requested a review from texodus November 23, 2021 02:50
@timkpaine
Copy link
Member Author

can squash please

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

- ${{ parameters.pythonCoverageSteps }}
- ${{ parameters.pythonMacWheelSteps }}

- job: "MacOS_BigSur"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

if platform.system() == "Windows":
import distutils.msvccompiler as dm

# https://wiki.python.org/moin/WindowsCompilers#Microsoft_Visual_C.2B-.2B-_14.0_with_Visual_Studio_2015_.28x86.2C_x64.2C_ARM.29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#tomatofarmer2022

@texodus texodus merged commit c92a32e into perspective-dev:master Nov 23, 2021
@texodus texodus added the internal Internal refactoring and code quality improvement label Dec 5, 2021
@timkpaine timkpaine deleted the tkp/windows branch December 11, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal refactoring and code quality improvement

Development

Successfully merging this pull request may close these issues.

Update windows-2016 to windows-latest and set up Visual Studio 2019 build

2 participants