fix cmake build error when install under virtualenv#1779
Merged
texodus merged 1 commit intoperspective-dev:masterfrom May 30, 2022
Merged
fix cmake build error when install under virtualenv#1779texodus merged 1 commit intoperspective-dev:masterfrom
texodus merged 1 commit intoperspective-dev:masterfrom
Conversation
timkpaine
approved these changes
May 16, 2022
Member
|
Thanks for the PR @shinny-chengzhi! Looks good! Apologies for the delay in merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake's
FindPythonLibsis not working very well under virtualenv. We need to setPYTHON_LIBRARYandPYTHON_INCLUDE_DIRto help CMake locate the relevant directories.PS: This new one is created because I can't change the source branch of PR #1777