Skip to content

Fix small memory leak and validate package.json with CI cache#1881

Merged
texodus merged 2 commits intomasterfrom
fix-stale-emsdk
Jul 3, 2022
Merged

Fix small memory leak and validate package.json with CI cache#1881
texodus merged 2 commits intomasterfrom
fix-stale-emsdk

Conversation

@texodus
Copy link
Member

@texodus texodus commented Jul 1, 2022

Fix a few small memory leaks which in aggregate caused OOM and other test stability issues, as per failing master build. This was not detected in CI as the emsdk cache was keyed on yarn.lock, while emsdk versions are not yarn dependencies.

One of these memory leaks was a string-length miscalculation in the join aggregate, as well as an assumption that these values already be strings; the fix for this behavior also fixes #1786

@texodus texodus requested a review from timkpaine as a code owner July 1, 2022 02:39
@texodus texodus added internal Internal refactoring and code quality improvement and removed cla-present labels Jul 1, 2022
@texodus texodus force-pushed the fix-stale-emsdk branch from 40b07ef to 7fd1e9f Compare July 1, 2022 02:42
@texodus texodus changed the title Revert to emsdk 3.1.9 and validate package.json with CI cache Revert to emsdk 3.1.3 and validate package.json with CI cache Jul 1, 2022
@texodus texodus marked this pull request as draft July 1, 2022 17:28
@timkpaine timkpaine self-requested a review July 1, 2022 18:36
@texodus texodus force-pushed the fix-stale-emsdk branch from 7fd1e9f to 2c84137 Compare July 3, 2022 08:56
@texodus texodus changed the title Revert to emsdk 3.1.3 and validate package.json with CI cache Fix small memory leak and validate package.json with CI cache Jul 3, 2022
@texodus texodus added bug Concrete, reproducible bugs and removed internal Internal refactoring and code quality improvement labels Jul 3, 2022
@texodus texodus marked this pull request as ready for review July 3, 2022 09:50
@texodus texodus merged commit cbcbcd6 into master Jul 3, 2022
@texodus texodus deleted the fix-stale-emsdk branch July 3, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Concrete, reproducible bugs

Development

Successfully merging this pull request may close these issues.

join aggregate is incorrect with certain data sets

2 participants