Merged
Conversation
texodus
added
enhancement
texodus
force-pushed
the
datetime-column-style
branch
from
5cdae98 to
e350443
Compare
texodus
force-pushed
the
datetime-column-style
branch
from
e350443 to
af7a4fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic
dateanddatetimeconfigurability to@finos/perspective-viewer-datagrid, based on theIntldateStyleandtimeStyleproperties, as well as support for overriding the browser session timezone with any supported locales.This feature does not support generic
sprintfstyle datetime format strings (asIntldoes not support these), nor does it support correcting for e.g. specific offsets in hour units (timezones are implemented by the browser and have locale-specific behavior).