Skip to content

A11y front page labels#2161

Merged
texodus merged 2 commits intoperspective-dev:masterfrom
julianna-ciq:a11y-front-page-labels
Apr 3, 2023
Merged

A11y front page labels#2161
texodus merged 2 commits intoperspective-dev:masterfrom
julianna-ciq:a11y-front-page-labels

Conversation

@julianna-ciq
Copy link

Documentation

(Both on the front page)

  • Added an aria-label to the Velocity range slider
  • Added descriptions for every example's thumbnail, and surfaced them as alt text.

Validation

I am presently unable to build Perspective in order to validate that this documentation works correctly. I have a discussion open to try to get myself to a point where I can build things.

However, I wanted to submit this PR ahead of time, in case anyone wants to review or change the image descriptions that I wrote.

  • I have linted, spell-checked, and grammar-checked my documentation additions.
  • I have run yarn docs to regenerate the API documentation from source.
  • Within /docs, I have run yarn start to regenerate the Docusaurus site, and I have validated the changes
  • My additions are styled and structured correctly on the Docusaurus site

Checklist

@finos-cla-bot
Copy link

finos-cla-bot bot commented Mar 30, 2023

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@julianna-ciq).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

cc @TheJuanAndOnly99 @mcleo-d

@timkpaine timkpaine added the documentation Improvements/bugs/changes to documentation label Mar 30, 2023
@timkpaine timkpaine requested a review from texodus March 30, 2023 21:45
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @julianna-ciq ! Looks good!

@texodus texodus merged commit 360ccf8 into perspective-dev:master Apr 3, 2023
@julianna-ciq julianna-ciq deleted the a11y-front-page-labels branch April 3, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements/bugs/changes to documentation

Development

Successfully merging this pull request may close these issues.

3 participants