Coerce to float64 when user tries to pass in float32 as float64 - fixes #1717

[justice-asare]

resolved #1717

Before

After

Some extra tests

[finos-cla-bot]

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@justice-asare).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

cc @TheJuanAndOnly99 @mcleo-d

[timkpaine]

These both work:

The code in the issue explicitly tells the table to use float (which is float64) which leads to it parsing the array as float64 instead of float32. I'm comfortable with these changes, which are more of a "help the user not make a mistake" rather than a bug fix, but they'll need tests added.

[justice-asare]

Could you please specify the tests that are required in more detail?

[timkpaine]

tests that cover the new code added

see the Pull request template
and Contributing docs

Please make sure PRs include:
Tests asserting behavior of any new or modified features.

[justice-asare]

@cla-bot[bot] check

[finos-cla-bot]

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement; having reviewed our contributor list, we require a CLA for the following people : (@justice-asare).

In order to sign a CLA with FINOS, just submit a Pull Request with a simple change to this file (adding an empty line, or some random text at the bottom); this will trigger the EasyCLA bot, which will post a comment to the Pull Request stating whether all PR contributors are covered by FINOS CLA; if not covered, the bot will post instructions on how to sign the CLA.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request. Feel free to email help@finos.org for any questions.

cc @TheJuanAndOnly99 @mcleo-d

[finos-cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[TheJuanAndOnly99]

@cla-bot[bot] check

[finos-cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[timkpaine]

There are likely more conversions for us to do outside the scope of the original ticket, but I'm happy with this change as is.

[justice-asare]

I'm glad to hear that you're satisfied with the current change.

[texodus]

@timkpaine I would like to see whatever changes you want in Issues if you can please!

[texodus]

Thanks for the PR! Looks good!