Fix sum aggregate for integer type expression columns#2216
Merged
texodus merged 1 commit intoperspective-dev:masterfrom May 7, 2023
Merged
Fix sum aggregate for integer type expression columns#2216texodus merged 1 commit intoperspective-dev:masterfrom
sum aggregate for integer type expression columns#2216texodus merged 1 commit intoperspective-dev:masterfrom
Conversation
zxy994
force-pushed
the
finos/fix-2036
branch
2 times, most recently
from
0e47b8d to
497da69
Compare
zxy994
force-pushed
the
finos/fix-2036
branch
3 times, most recently
from
497da69 to
29ee00a
Compare
texodus
changed the title
sum aggregate for integer type expression columns
Contributor
Author
|
@texodus Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2036 Column expr of integer column sum renders all rows as 0
BEFORE:
AFTER:
