Add Travis node_modules caching#229
Merged
texodus merged 3 commits intoperspective-dev:masterfrom Sep 5, 2018
LukeSheard:travis-steps
Merged
Add Travis node_modules caching#229texodus merged 3 commits intoperspective-dev:masterfrom LukeSheard:travis-steps
texodus merged 3 commits intoperspective-dev:masterfrom
LukeSheard:travis-steps
Conversation
Member
|
Thanks for the PR! While I'm happy to merge this, it's worth noting that we actually used Travis caching before for node_modules (and docker images) and ended up removing it. When we had it, it seemed the caching did not actually speed up the build at all (and notice the travis build times from this PR are inline with previous builds). However, they did cause infrequent issues with cached images being out of date, or corrupted images being cached. I'll keep an eye on this, and if it is still an issue we'll need to back this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should improve travis build times slightly.