Datagrid column header configuration UX update#2351
Merged
Conversation
texodus
added
enhancement
texodus
force-pushed
the
fix-column-header-buttons
branch
from
6fa920f to
6d9baa6
Compare
texodus
force-pushed
the
fix-column-header-buttons
branch
from
6d9baa6 to
25fb269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restructures the column header's
stylebutton, from a CSS:beforehack special, into a dedicated<tr>row in the DOM into which we can put arbitrary components. This change is purely aesthetic from a UX perspective for now, but it lays the groundwork for some additional style configuration improvements coming soon.Before:
After:
