Serialize Expressions to Objects#2436
Merged
texodus merged 1 commit intoperspective-dev:masterfrom Nov 17, 2023
Merged
Conversation
texodus
approved these changes
Nov 17, 2023
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good!
| #[derive(Deserialize, Clone, PartialEq, Debug)] | ||
| #[serde(untagged)] | ||
| pub enum Expressions { | ||
| pub enum ExpressionsDeserde { |
Member
There was a problem hiding this comment.
What makes this type unique that it requires the qualifier Deserde in the name (as opposed to the other components of ViewerConfig)? There is no other Expressions type, so the fact that it only supports deserialization doesn't disambiguate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes expression serialization so that expressions will always serialize to objects while allowing users to import array-based expressions.