Conversation
texodus
added
internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perspective-viewermigration code. Import assertions are not well standardized in older build tools, causing these statements to fail compilation with some tools where previous perspective versions did not. Perspective'sdocusaurussite exhibited this behavior, though we did not run it in CI, discovered after2.7.1was released.docsbuild to CI so this does not happen againdocusaurussite to fail compilation.plugin_configis an optional key, and looking up anything (in this case.columns) on this may be a lookup on undefined. The migration scripts must be very defensive about this; going forward, CI will fail more regularly when regressions are introduced due to Jest #2 above.