Expansion depth should be stable across updates#277
Merged
texodus merged 10 commits intoperspective-dev:masterfrom Oct 19, 2018
nmichaud:expansion-depth
Merged
Expansion depth should be stable across updates#277texodus merged 10 commits intoperspective-dev:masterfrom nmichaud:expansion-depth
texodus merged 10 commits intoperspective-dev:masterfrom
nmichaud:expansion-depth
Conversation
Member
|
Looks great, thanks for the PR! |
LukeSheard
reviewed
Oct 19, 2018
| * | ||
| */ | ||
| view.prototype.expand_to_depth = async function(depth) { | ||
| view.prototype.set_depth = async function(depth) { |
Contributor
There was a problem hiding this comment.
Given that this is a breaking change would it not be better to deprecate the old functions? (Unless they’ve not been released from master yet?)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a context has the expansion depth set, new nodes that tick in aren't automatically expanded to that depth. This PR fixes that.