Escape esbuild plugin's symbol replacement.#2807
Merged
texodus merged 1 commit intoperspective-dev:masterfrom Oct 28, 2024
Merged
Escape esbuild plugin's symbol replacement.#2807texodus merged 1 commit intoperspective-dev:masterfrom
texodus merged 1 commit intoperspective-dev:masterfrom
Conversation
Signed-off-by: Timothy Bess <tim@prospective.dev>
timbess
force-pushed
the
bugfix/fix-esbuild-symbol-escaping
branch
from
6d2e8af to
59aa070
Compare
texodus
approved these changes
Oct 28, 2024
Member
texodus
left a comment
texodus
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minification sometimes adds
$to variable names causing it to be interpreted as regex rather than literally.