Skip to content

Show appropriate date when date is part of grouped data on chart.#2857

Merged
texodus merged 6 commits intoperspective-dev:masterfrom
onesimus-wiafe:plugin/fix_epoch_time_to_date_on_axis_label
Feb 27, 2025
Merged

Show appropriate date when date is part of grouped data on chart.#2857
texodus merged 6 commits intoperspective-dev:masterfrom
onesimus-wiafe:plugin/fix_epoch_time_to_date_on_axis_label

Conversation

@onesimus-wiafe
Copy link
Contributor

@onesimus-wiafe onesimus-wiafe commented Nov 19, 2024

This PR addresses issue #2566. When the data is grouped and a date is part of the grouped data, the date values are then represented in epoch format. I couldn't figure out the exact source of the problem, and this solution addresses the problem. I included a function in the filter.ts file since all the plugins affected by this issue import the functions in filter.ts. I refine the date type values before the functions in filter.ts run. The tests included confirm this solution too.

Pull Request Checklist

  • Description which clearly states what problems the PR solves.
  • Description contains a link to the Github Issue, and any relevent
    Discussions, this PR applies to.
  • Include new tests that fail without this PR but passes with it.
  • Include any relevent Documentation changes related to this change.
  • Verify all commits have been signed in accordance with the DCO policy.
  • Reviewed PR commit history to remove unnecessary changes.
  • Make sure your PR passes build, test and lint steps completely.

sarpong4 and others added 2 commits November 25, 2024 17:53
…elected

Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
Co-authored-by: asrar <aszenz@gmail.com>
Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
@onesimus-wiafe onesimus-wiafe force-pushed the plugin/fix_epoch_time_to_date_on_axis_label branch from d23bc03 to 2f967db Compare November 25, 2024 18:18
Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I suspect some parts of this PR are AI generated. We do not yet have an official project policy on this, but I'm not eager to review such code. If you're going to use these tools, please rigorously check for relevance, brevity and sanity before submitting - technically correct code is not enough. If this is not AI generated code - please do this anyway.

Regardless of the tooling, I would like some cleanup of this code before we merge it (see review comments).

Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
Signed-off-by: Onesimus Wiafe <onesimus.wiafe@turntabl.io>
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@texodus texodus added the bug Concrete, reproducible bugs label Feb 27, 2025
@texodus texodus merged commit 7ce0150 into perspective-dev:master Feb 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Concrete, reproducible bugs

Development

Successfully merging this pull request may close these issues.

[Chart Plugin] Multi-tier grouping by date displays epoch time in axis label

4 participants