Skip to content

C++ Date Validation#396

Merged
texodus merged 2 commits intomasterfrom
date-parser
Jan 23, 2019
Merged

C++ Date Validation#396
texodus merged 2 commits intomasterfrom
date-parser

Conversation

@sc1f
Copy link
Contributor

@sc1f sc1f commented Jan 23, 2019

  1. Add a date parser on the C++ side that correctly validates date/datetime strings using the iomanip header.
  • The parser is not called by any running code, nor is it included in CMakeLists.txt.
  • The header does not include support for milliseconds and timezones, which is fine for string validation but will be problematic for parsing.
  1. Added tests for the date parser, and moved computed column tests into their own describe block.
  2. Fixed the use of now-undefined PSP_ABORT in PSP_VERBOSE_ASSERT2.

sc1f added 2 commits January 23, 2019 12:07
WIP: c++ date_parser

WIP: include custom boost exception handler

use std::get_time instead of boost
@texodus
Copy link
Member

texodus commented Jan 23, 2019

Thanks for the PR!

@texodus texodus merged commit d580705 into master Jan 23, 2019
@texodus texodus deleted the date-parser branch January 23, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants