Conversation
Member
Author
|
Discussed offline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds simple smoke/integration tests to
perspective-viewer-d3fc, using the same puppeteer/record matching approach used byperspective-viewerand friends, details of which can be found in the perspective documentation. These tests are designed to prevent us from merging changes which "obviously" break the plugin, rather than provide fine-grained feedback as to what failed; as such, they are really meant to be run mostly by travis, and before opening a PR, rather than iteratively during development.The tests also assert that the Chrome console logs no errors while running - and one fix for tooltips was needed to achieve this, checking that the SVG tree itself is still attached to the DOM.