Merged
Conversation
…ring to lose precision
…skip_headers and merge into templated get_data
The modified d3fc axis component is likely to look mostly like this. The multi-axis component may or may not make it into d3. We split the axis into multiple levels in Perspective code, then give that information to the multi-axis
…into jpmorganchase-master
Merge/jpmorganchase master
Shouldn't show legend when only one series (scale range is 1)
Fixed legend when only one series
Added integration screenshot tests for more d3fc charts
Update plugin
…results.json file
refresh screenshots and update shares-template
Refresh screenshots
Add git commit
update plugin
Switched to new d3fc canvas gridline component
Merge unit test functionality from perspective master
Fix build error and add unit test support
Member
|
Thanks for the PR! Looks great! The draggable legend really cries out for a persistence API for plugins, especially wrt streaming data - we'll be working on that for th v0.2.22 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the d3fc plugin including:
Draggable Legend
Legend can be selected and dragged to a different location on the chart
bollinger bands and moving average
Theme chart series from CSS and theme file
This allows users to easily override the theme with a bespoke css file or override specific pages with inline style sections