Calculate row offset in C++, refactor Table, remove implicit primary key mode#692
Merged
Calculate row offset in C++, refactor Table, remove implicit primary key mode#692
Conversation
Member
|
Looks good, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the workings of the
Tableclass and ports over some more functionality from JS to C++. Most importantly, thelimit_index/offsetproperty is now calculated within theTableclass, which removes another chunk of state-dependent JS code.GNODE_TYPE_IMPLICIT_PKEYEDwhich is not being used in the production codebase, and conflicts with features already present.